Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ISO 3166 locale codes #4316

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Support ISO 3166 locale codes #4316

merged 10 commits into from
Jul 21, 2020

Conversation

TheoChevalier
Copy link
Contributor

@TheoChevalier TheoChevalier commented Mar 9, 2020 •
edited
Loading

Closes #4314

  • Backporting the work done on donate-wagtail to support ab-CD locale codes.
  • Not touching anything related to Portuguese here, but that should allow us to migrate to pt-BR later on (if there’s a way to migrate).
  • Adding support for fy-NL in order to test things easily, and because we would like to support it on the MozFest site.
  • I’ve fixed the language switcher, as it was relying on two-letter codes. Explanation of the fix
  • I’ve made my translation_management.sh script dynamic to support a list of locales that need to be copied from ab-CD into ab_CD during Django string extraction process.
    UPDATE: I managed to leverage relative symlinks in the fomo-1l0n repo to entirely get rid of moving files between ab-CD and ab_CD folders. Or even to pt for Portuguese.

Most of the code comes from these two commits:
MozillaFoundation/donate-wagtail@f582d53
MozillaFoundation/donate-wagtail@d3bfd00

Adding Pomax as reviewer, since he reviewed the original fix

@TheoChevalier TheoChevalier requested a review from Pomax March 9, 2020 20:56
@TheoChevalier TheoChevalier self-assigned this Mar 9, 2020
@patjouk patjouk temporarily deployed to foundation-s-iso-3166-l-f8vhdx March 9, 2020 20:57 Inactive
@cadecairos cadecairos added this to the Mar 23 milestone Mar 10, 2020
@patjouk patjouk temporarily deployed to foundation-s-iso-3166-l-f8vhdx March 11, 2020 18:51 Inactive
@patjouk patjouk temporarily deployed to foundation-s-iso-3166-l-f8vhdx March 11, 2020 19:59 Inactive
@patjouk patjouk temporarily deployed to foundation-s-iso-3166-l-f8vhdx March 12, 2020 12:26 Inactive
@cadecairos cadecairos modified the milestones: Mar 23, Apr 6 Mar 24, 2020
@cadecairos cadecairos modified the milestones: Apr 6, May 4 Apr 8, 2020
@kristinashu kristinashu removed this from the May 4 milestone Apr 13, 2020
@TheoChevalier TheoChevalier force-pushed the iso-3166-locales branch 2 times, most recently from 99508c9 to 17a99ac Compare May 12, 2020 13:42
@cadecairos cadecairos modified the milestones: May 18, June 2 May 12, 2020
@mofodevops mofodevops temporarily deployed to foundation-s-iso-3166-l-x0wgvj June 25, 2020 11:49 Inactive
Pomax
Pomax suggested changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor things

network-api/networkapi/wagtailpages/__init__.py Outdated Show resolved Hide resolved
network-api/networkapi/wagtailpages/__init__.py Outdated Show resolved Hide resolved
@Pomax
Copy link
Contributor

Pomax commented Jul 9, 2020

@TheoChevalier we can probably land this soon, I rebased and fixed the migrations (because we did a significant squashing since this PR got opened, so the migration dependencies had completely changed), but there's only the two comments.

@TheoChevalier @Pomax
Update network-api/networkapi/wagtailpages/__init__.py
33b69c1 
Co-authored-by: Pomax <pomax@nihongoresources.com>
@TheoChevalier
Copy link
Contributor Author

@Pomax Thank you! And sorry I haven’t had much time to look into this today

@Pomax
Copy link
Contributor

Pomax commented Jul 15, 2020

@TheoChevalier let's get this landed before the end of this week? =)

@TheoChevalier
Copy link
Contributor Author

@Pomax Sorry for the wait, finally took the time to file https://code.djangoproject.com/ticket/31795
Updated the comment with that ticket

@TheoChevalier TheoChevalier requested a review from Pomax July 16, 2020 16:17
@mergify mergify bot merged commit abb1c49 into master Jul 21, 2020
@mergify mergify bot deleted the iso-3166-locales branch July 21, 2020 18:29
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pomax Pomax Pomax approved these changes

Assignees

@TheoChevalier TheoChevalier

Labels
engineering localization 🌎
Projects
None yet
Milestone
June 2
Development

Successfully merging this pull request may close these issues.

Support ISO 3166 locale codes
6 participants
@TheoChevalier @Pomax @cadecairos @patjouk @kristinashu @mofodevops